Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip failing twisted.web.test.test_http.QueryArgumentsTests.testParseqs #1523

Merged
merged 4 commits into from Feb 26, 2021

Conversation

graingert
Copy link
Member

@graingert graingert commented Feb 23, 2021

Scope and purpose

the stdlib parse_qs has changed behaviour with regard to splitting query parameters on ;

Python 3.6.13 (2021-02-16) fixed by commit 5c17dfc (branch 3.6) (2021-02-15)
Python 3.7.10 (2021-02-16) fixed by commit d0d4d30 (branch 3.7) (2021-02-15)
Python 3.8.8 (2021-02-19) fixed by commit e3110c3 (branch 3.8) (2021-02-15)
Python 3.9.2 (2021-02-19) fixed by commit c9f0781 (branch 3.9) (2021-02-15)

this is causing CI to fail

Remove this section

Please have a look at our developer documentation before submitting your Pull Request.

Please note that the trac ticket, news fragment, and review submission portions of this process apply to all pull requests, no matter how small; if you don't do them, it's likely that nobody will even notice your PR needs a review.

Contributor Checklist:

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Please use a different trac ticket for the skip PR.

We can keep https://twistedmatrix.com/trac/ticket/10096 for the real fix :)

Only minor comments. Address them as you like and merge. Thanks!

src/twisted/web/newsfragments/10096.bugfix Outdated Show resolved Hide resolved
src/twisted/web/test/test_http.py Show resolved Hide resolved
@graingert graingert merged commit 1e4c7ae into twisted:trunk Feb 26, 2021
@graingert graingert deleted the skip-failing-parse-qs-test branch February 26, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants