Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10102] Add towncriertox env. #1527

Merged
merged 1 commit into from Feb 28, 2021
Merged

[10102] Add towncriertox env. #1527

merged 1 commit into from Feb 28, 2021

Conversation

adiroiban
Copy link
Member

Scope and purpose

This adds a towncrie tox env to make it a bit easier to create the news fragment.

Another option , is to update the release docs not to required using tox to call towncrier.

Contributor Checklist:

Copy link
Contributor

@rodrigc rodrigc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK. This is too late to make it into the 21.2.0 release,
but it is not a release blocker, since I can run towncrier outside of tox when doing the release.

@adiroiban adiroiban merged commit 4f322d9 into trunk Feb 28, 2021
@adiroiban adiroiban deleted the 10102-add-towncrier-env branch February 28, 2021 08:31
@adiroiban
Copy link
Member Author

Thanks for the review. No problem if this is not included in the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants