Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10214] Release Twisted 21.7.0 #1614

Merged
merged 26 commits into from
Jul 28, 2021
Merged

[10214] Release Twisted 21.7.0 #1614

merged 26 commits into from
Jul 28, 2021

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Jul 6, 2021

Scope and purpose

This is the PR for the 21.7.0 release series.

For now this PR and branch is WIP as I am trying/testing the release process.

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/10214
  • I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • [NA] I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • [NA] I have updated the automated tests and checked that all checks for the PR are green.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #123 from twisted/4356-branch-name-with-trac-id

Author: adiroiban
Reviewer: 
Fixes: ticket:10214

Release Twisted 21.7.0

@graingert
Copy link
Member

I'd like to upgrade ci to 3.10b3 before release

@graingert
Copy link
Member

#1615

@adiroiban adiroiban marked this pull request as draft July 6, 2021 17:43
@adiroiban
Copy link
Member Author

I will not release it just yet. I have marked it as a draft.

I still need to fix the CheckNewsfragmentScript and it looks like it was red even for a branch starting with 'release-'

@adiroiban adiroiban marked this pull request as ready for review July 10, 2021 11:24
NEWS.rst Outdated Show resolved Hide resolved
NEWS.rst Outdated Show resolved Hide resolved
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@adiroiban adiroiban requested a review from a team July 12, 2021 08:27
@adiroiban
Copy link
Member Author

Many thanks for the review. I have applied to changes.

I will not keep this branch up to date... as this is the release note.
I will add a info to the release documentation about this.

NEWS.rst Outdated Show resolved Hide resolved
@graingert graingert changed the title [10214] Release Twsted 21.7.0 [10214] Release Twisted 21.7.0 Jul 12, 2021
NEWS.rst Outdated Show resolved Hide resolved
@adiroiban adiroiban requested a review from a team July 15, 2021 08:54
@adiroiban
Copy link
Member Author

This is ready for the final release.
I am doing some fast-tracking here (as I now have some time)
But I plan to push the final release only on Saturday 17 of July, to allow for a full 1 week of feedback for the release candidate.

@adiroiban
Copy link
Member Author

Thanks Thomas for the review and merge.

The next step on this branch is to do the 21.7.0rc2

@graingert
Copy link
Member

17:10:00 I will push the RC2 release tonight or tomorrow ...and after that, in 2 days we should be able to do the final release... if no other issues are found.

10230 work around bpo-44070 by making filenames absolute before calling spec_from_file_location
NEWS.rst Outdated Show resolved Hide resolved
@glyph
Copy link
Member

glyph commented Jul 22, 2021

Oops! Let me un-commit that.

Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs 10235 and 10236

@adiroiban
Copy link
Member Author

@graingert I will not be over IRC today.
If there is anything to review or check for the release you can mention me over GitHub. Thanks

@graingert
Copy link
Member

graingert commented Jul 26, 2021

@adiroiban

If there is anything to review or check for the release you can mention me over GitHub. Thanks

I tried out:

twisted[tls]==21.7.0rc3 \
    --hash=sha256:1e662b39390201187504399eaeb24c41dcf0fc5f1a9625d9fc89a15e6d6aa433 \
    --hash=sha256:5946ba6fd19f0a441548b1ff4e0ce8108efdfef090a8310017f1213cc1151439

on my test suite and everything now passes

@adiroiban adiroiban requested review from graingert and a team July 26, 2021 14:51
@adiroiban
Copy link
Member Author

Twisted 21.7.0 is ready for the final review.
The important part is to make sure the release notes make sense.

Thanks!

NEWS.rst Outdated Show resolved Hide resolved
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find myself wishing we had a documentation section for type-related changes, but the changelog LGTM.

@adiroiban
Copy link
Member Author

Thanks for the review. I will trigger the release.

I find myself wishing we had a documentation section for type-related changes, but the changelog LGTM.

We can add a .type or .typing fragment category.

@adiroiban
Copy link
Member Author

@adiroiban adiroiban requested review from graingert, twm and a team July 28, 2021 09:13
@adiroiban adiroiban merged commit a4171dc into trunk Jul 28, 2021
@adiroiban adiroiban deleted the release-21.7.0-10214 branch July 28, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants