-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10214] Release Twisted 21.7.0 #1614
Conversation
|
I'd like to upgrade ci to 3.10b3 before release |
|
I will not release it just yet. I have marked it as a draft. I still need to fix the CheckNewsfragmentScript and it looks like it was red even for a branch starting with 'release-' |
f269144
to
eff33fd
Compare
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
|
Many thanks for the review. I have applied to changes. I will not keep this branch up to date... as this is the release note. |
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
|
This is ready for the final release. |
|
Thanks Thomas for the review and merge. The next step on this branch is to do the 21.7.0rc2 |
|
10230 work around bpo-44070 by making filenames absolute before calling spec_from_file_location
|
Oops! Let me un-commit that. |
6576827
to
c02a290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs 10235 and 10236
…l-repr 10235 accept non-function callables in LoopingCall and DeferLater
|
@graingert I will not be over IRC today. |
I tried out: on my test suite and everything now passes |
|
Twisted 21.7.0 is ready for the final review. Thanks! |
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find myself wishing we had a documentation section for type-related changes, but the changelog LGTM.
|
Thanks for the review. I will trigger the release.
We can add a |
Scope and purpose
This is the PR for the 21.7.0 release series.
For now this PR and branch is WIP as I am trying/testing the release process.
Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standard#character).reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.The first line is automatically generated by GitHub based on PR ID and branch name.
The other lines generated by GitHub should be replaced.