-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10218 pre-commit autoupdate #1619
Conversation
for more information, see https://pre-commit.ci
|
I don't know what to say. What problem does it tries to solve? With the recent supply-chain attacks I prefer to review twice before giving write access to external services. Also, I am a bit worried that without auto-cancelling of the old jobs, with pre-commit.ci enabled we generate twice as many test jobs... once for the original PR push and then another one for the fixes done by pre-commit.ci I guess that pre-commit.ci can help with nodejs/Ruby/golang project where developers don't have a python environment available. but Twisted is based on python so it shouldn't be a big issue for Twisted developers to install and enable pre-commit and use it as a real pre-commit hook :) At the same time, I think that core developers can enable the pre-commit locally and for that case pre-commit.ci will be a NOOP as all the pre-commit changes were already done. I am not completely against it, on this as I guess that it might help first time contributors . Without a PR description I can only guess why and what this PR does. I prefer to approve the PR based on a short info from @graingert to describe what issue this PR tries to solve so that I can do a review based on that info and not based on a guess :) I think that it would help to get at least another review from at least another Twisted developer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged...
but can you also apply in this PR the changes from https://github.com/twisted/twisted/pull/1626/files
so that we don't need a separate review.
Thanks again!
Scope and purpose
Since initially introducing pre-commit many hooks have been updated with fixes - eg pyupgrade, flake8 and black.
This PR updates those hooks and then allows pre-commit.ci to run them to demonstrate that all the changes are from real hook changes and I didn't try to slip anything hidden in with them.
Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standard#character).reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.The first line is automatically generated by GitHub based on PR ID and branch name.
The other lines generated by GitHub should be replaced.