Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10291 fix trunk build #1681

Merged
merged 3 commits into from Jan 15, 2022
Merged

10291 fix trunk build #1681

merged 3 commits into from Jan 15, 2022

Conversation

glyph
Copy link
Member

@glyph glyph commented Jan 14, 2022

Scope and purpose

build is red, now its not

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/10291
  • I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • I have updated the automated tests and checked that all checks for the PR are green.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #1681 from twisted/10291-fix_build

Author: glyph
Reviewer: 
Fixes: ticket:10291

Tests are now passing again; some python3.6 builds and the pypy3.6 build were dropped.

@glyph glyph changed the title wow azure is *on the ball* when it comes to removing unsupported vers… 10291 fix trunk build Jan 14, 2022
Copy link
Member

@adiroiban adiroiban left a comment

I think that this is can be merged. Thanks!

@glyph glyph merged commit 29535e5 into trunk Jan 15, 2022
15 checks passed
@glyph glyph deleted the 10291-fix_build branch Jan 15, 2022
@glyph
Copy link
Member Author

glyph commented Jan 15, 2022

Thanks for the quick review @adiroiban ! Time to merge trunk into every PR in the world :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants