Convert scripts in bin to console_scripts #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.15%@@ trunk #224 diff @@
==========================================
Files 821 821
Lines 143746 143709 -37
Methods 0 0
Messages 0 0
Branches 13472 13468 -4
==========================================
+ Hits 127390 129567 +2177
+ Misses 13959 11895 -2064
+ Partials 2397 2247 -150
|
|
looks like some of the builders need to be updated |
rodrigc
force-pushed
the
8491-rodrigc-console
branch
from
ae8972e
to
8d6b47c
Compare
This was referenced Jun 27, 2016
|
@adiroiban: why is codecov showing 71.42% coverage here: https://codecov.io/gh/twisted/twisted/compare/8dd2292cac9be85a9f81aef336c35bdb89f46e1c...87cb6c0d9af66591d218bd53684d58e15601daf4 It looks like it is not reporting coverage of the _PY3 block. Isn't the https://buildbot.twistedmatrix.com/builders/fedora22-py3.4-coverage build uploading coverage results to codecov.io ? |
| @@ -43,7 +43,9 @@ def main(args): | |||
| packages=setuptools.find_packages(), | |||
| install_requires=requirements, | |||
| conditionalExtensions=getExtensions(), | |||
| scripts=getScripts(), | |||
| entry_points={ | |||
| 'console_scripts': getConsoleScripts() | |||
rodrigc
force-pushed
the
8491-rodrigc-console
branch
8 times, most recently
from
9e8826d
to
f8c80dc
Compare
Remove getScripts()
twisted.python.dist.getScripts() was removed during the conversion to the console_scripts entry point.
These scripts are now installed by the console_scripts entry point in setup.py.
rodrigc
force-pushed
the
8491-rodrigc-console
branch
from
f8c80dc
to
a001904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
http://twistedmatrix.com/trac/ticket/8491