Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Port python zippath #26
Hey @glyph! Thanks for reaching out on github. When I was working on this I decided to kind of track it in parallel on both systems for some reason. Here's the trac ticket: https://twistedmatrix.com/trac/ticket/6917
My fixes were messy and gross because I wanted to get something that seemed to work out there to get feedback sooner. Along the way I learned a lot about how zip files are kind of broken in python3, and then @itamarst pointed out that a better solution might be to just disable zip file support in python3 since it's only used for loading packages stored as zips. I wanted to try to implement that before getting more feedback but hit a total roadblock and ran out of free time for it.
Looking back at this, you're right that I shouldn't have opened up multiple places for my submission. This PR should probably be closed.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Comments aren't disabled. They're just privileged. See https://twistedmatrix.com/pipermail/twisted-python/2014-June/028439.html