Deprecated twisted.internet.defer.TimeoutError in favor of twisted.internet.error.TimeoutError #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove reference in docstring to Deferred.setTimeout, which was removed in 0d2674c
…net.error.TimeoutError
Use deprecatedModuleAttribute()
| @@ -25,10 +25,12 @@ | |||
| from functools import wraps | |||
|
|
|||
| # Twisted imports | |||
| import twisted.internet.error | |||
There was a problem hiding this comment.
to have shorter named in the rest of the code I think that we should just do
from twisted.internet import error
| @@ -2357,7 +2357,7 @@ def test_waitUntilLockedWithTimeoutUnlocked(self): | |||
| but the lock is unlocked before our timeout. | |||
| """ | |||
| def onTimeout(f): | |||
| f.trap(defer.TimeoutError) | |||
| f.trap(error.TimeoutError) | |||
There was a problem hiding this comment.
here is a missing coverage which will block the merge :(
There was a problem hiding this comment.
How do I test that? That code is inside a test that is supposed to be testing a condition that is never supposed to happen.
There was a problem hiding this comment.
Good question :)
I would say that we should have a # pragma: no-cover comment to let coverage know that this line should be ignored
... but first, let's talk about it over the mailing list. I will start the conversation :)
Thanks!
|
Closing, as per feedback in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
http://twistedmatrix.com/trac/ticket/8533