Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix twisted/internet/test/test_win32events.py on Python3 #284

Merged
merged 3 commits into from
Jul 3, 2016

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Jul 1, 2016

@codecov-io
Copy link

codecov-io commented Jul 1, 2016

Current coverage is 88.53%

Merging #284 into trunk will decrease coverage by 1.63%

@@              trunk       #284   diff @@
==========================================
  Files           819        819           
  Lines        143327     143327           
  Methods           0          0           
  Messages          0          0           
  Branches      13168      13168           
==========================================
- Hits         129241     126894   -2347   
- Misses        11843      14043   +2200   
- Partials       2243       2390    +147   

Powered by Codecov. Last updated by 5f9c663...4a5903d

@alex
Copy link
Member

alex commented Jul 1, 2016

👍 lgtm

@rodrigc
Copy link
Contributor Author

rodrigc commented Jul 1, 2016

This patch should have 100% coverage, not 57.14%
It looks like uploading codecov results from the Windows buildbot is not working.

This Windows build ran and tried to upload coverage results to codecov:

https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7-coverage/builds/623/steps/shell_5/logs/stdio

but failed with this:

Error: 403 Client Error: Forbidden for url: https://codecov.s3.amazonaws.com/v4/raw/2016-07-01/BB05435E28F8047E9B3D49B4B7BFA4B3/4a5903d2f0fcab3db7c6ca68ff563e2c859dd5c2/031e0d8f-aadc-47ae-9b69-29ca9d962287.txt?AWSAccessKeyId=AKIAIHLZSCQCS4WIHD4A&Expires=1467374016&Signature=i1IQndDSPC0vtJysR8vnPxDpPw0%3D

The upload failed, but the buildbot job reported success.

It looks like all uploads from windows7-64-py2.7-coverage are failing with this error.

@rodrigc rodrigc merged commit 502f3a1 into trunk Jul 3, 2016
@rodrigc rodrigc deleted the 8548-rodrigc-thread branch July 4, 2016 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants