Fix on Python 3: pip install -e ".[dev]" #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.84%@@ trunk #287 diff @@
==========================================
Files 819 773 -46
Lines 143365 140763 -2602
Methods 0 0
Messages 0 0
Branches 13168 11995 -1173
==========================================
- Hits 129281 126471 -2810
+ Misses 11841 11749 -92
- Partials 2243 2543 +300
|
| scripts=getScripts(), | ||
| include_package_data=True, | ||
| zip_safe=False, | ||
| extras_require=_EXTRAS_REQUIRE, |
There was a problem hiding this comment.
This is really minor, but this diff adds unnecessary churn here. Let's avoid re-ordering things that were already there (conditionalExtensions, zip_safe, and include_package_data), given that all we're doing is add extras_require.
There was a problem hiding this comment.
I changed the order to make the order the same as in setup.py.
Since setup3.py is using more and more stuff from dist.py, I made the change to make it easier to compare setup.py and setup3.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
http://twistedmatrix.com/trac/ticket/7807