Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please file tickets on https://twistedmatrix.com/ - Pull requests are, unfortunately, ignored. #46

Closed
wants to merge 588 commits into from

Conversation

glyph
Copy link
Member

@glyph glyph commented Aug 14, 2014

Github won't let us disable pull requests, so hopefully this stand-in will help some people find out what to do instead. The fact that it has conflicts in it will avoid anyone accidentally clicking the button to merge it.

Instead, see the guidelines for filing tickets against Twisted and the instructions for using Git for doing so, and if you're interested in helping the project accept pull requests, the issue for helping us migrate our infrastructure to Git.

hawkowl and others added 17 commits May 21, 2015 05:46
…s that the tests need on Py3

Author: hawkowl
Reviewer: adiroiban
Fixes: #7876

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44887 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: hawkowl
Reviewer: herrwolfe
Fixes: #7898

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44888 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
This breaks on Windows! Windows doesn't have git, and it got caught in the "oh there's one failure on Windows". Whoops.

Reopens: #7035

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44892 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…rsion

Author: multani, hawkowl
Reviewers: adiroiban, moshez
Fixes: #7035

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44897 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: hawkowl
Reviewer: adiroiban
Fixes: #7834

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44898 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…() in inspectCertificate test

Author: glyph

Reviewer: hawkowl

Fixes: #7908

This is necessary to support Debian 8 as a platform, since Debian 8 has
an OpenSSL which gives (validly) distinct results for this method.  We
should still upgrade public key hashing at some point in the future,
perhaps when cryptography offers an API for it, so we don't need this
workaround forever.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44903 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: hawkowl
Reviewers: moshez, exarkun
Fixes: #7884

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44905 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: hawkowl
Reviewer: adiroiban
Fixes: #7905

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44906 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: dustin
Reviewers: adiroiban, hawkowl
Fixes: #7845

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44911 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: hawkowl
Reviewers: adiroiban, exarkun, moshez
Fixes: #7874

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44931 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…ogramFilesPath in win32.py.

Author: opalmer
Reviewers: exarkun, adiroiban
Fixes: #7883

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44954 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…in win32.py."

Tests are broken due to an untested last minute refactoring.

Reopens: #7883

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44962 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…sitor

Author: hawkowl
Reviewer: sigmavirus24
Fixes: #7919

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44974 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
… code to py3 syntax to help port trial.

Author: adiroiban
Reviewer: moshez
Fixes: #7915

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@44988 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…ncontainers

Author: hawkowl
Reviewers: adiroiban, hynek
Fixes: #7920

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45005 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
seriously is rather ironic, yes

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45006 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: eeshangarg

Reviewer: glyph

Fixes: #7897

twisted.internet.protocol.Factory now uses the new logging
system (twisted.logger) for all its logging statements.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45008 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
hawkowl and others added 12 commits June 9, 2015 13:38
Author: hawkowl
Reviewer: adiroiban
Fixes: #7906

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45015 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: jml
Reviewer: adiroiban
Fixes: #7937

Fixes many PEP 8 and Twisted coding standard violations in
twisted/conch/unix.py

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45042 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: adiroiban
Reviewer: hawkowl
Fixes: #7931

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45077 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
….server

Author: vladius
Reviewer: adiroiban
Fixes: #7949

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45109 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: jml
Reviewer: hawkowl
Fixes: #7936

Previously, Conch's Unix server would only set HOME when running shell
commands. Now, it also sets it when running commands without a shell.

Much of the time to find and fix this bug was provided by ClusterHQ.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45118 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: hawkowl
Reviewer: adiroiban
Fixes: #7952

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45119 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…ogramFilesPath in win32.py.

Author: opalmer
Reviewers: exarkun, adiroiban, hawkowl
Fixes: #7883

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45121 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…d to Python 3

Author: hawkowl
Reviewer: adiroiban
Fixes: #7940

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45124 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…PRE in twistsed code.

Author: adiroiban
Reviewers: _sunu_, hawkowl
Fixes: #7942

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45133 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: glyph

Reviewer: hawkowl, adiroiban

Fixes: #7827

twisted.persisted is not a good package. don't use it. But, some things
within Twisted still use it, and attempting to work around its absence
while porting those things to python 3 was taking more time than just
porting the code, so that's what this change does.  some parts of
it (such as crefutil) are actually used by reasonable things we intend
to keep maintaining, such as jelly, so this brings the quality of the
code up a little bit and improves coverage as well.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45146 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…ython 3

Author: hawkowl
Reviewer: adiroiban
Fixes: #7817

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45163 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: hawkowl
Reviewer: adiroiban
Fixes: #6136

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@45178 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
adiroiban and others added 17 commits April 15, 2016 06:34
git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/branches/removeoldreflect-8293@47251 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: tom.prince

Reviewer: glyph

Fixes: #8277

twisted.mail.test.test_imap.IMAP4ServerTests.testPartialAppend was
touching an installed file for no discernable reason; remove that
unnecessary code.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47258 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: adiroiban
Reviewer: hawkowl, glyph
Fixes: #8082

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47279 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…Python 3

Author: hawkowl
Reviewer: adiroiban
Fixes: #8299

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47288 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: mithrandi
Reviewer: glyph
Fixes: #8300

Optimize template flattening by passing the write callable down into the
flattener and calling it directly, instead of yielding strings (often
very small strings) back up to the driver.

This yields a significant speed increase on PyPy, and a moderate one on
CPython.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47298 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…andard to reflect current best practice.

Author: hawkowl
Reviewers: radix, adiroiban
Fixes: #8256

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47302 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…rt backing the HTTPChannel object from twisted.web Resource objects."

Reopens: #8191

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47304 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…PCServer and RPCServicesConf.

Author: adiroiban
Reviewer: glyph
Fixes: #8123

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47323 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…rs in twisted.enterprise.adbapi.

Author: hawkowl
Reviewer: adiroiban
Fixes: #8304

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47332 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47333 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: adiroiban
Reviewer: glyph
Fixes: #5645

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47340 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…nel both sending a failure and processing a request with an invalid final header.

Author: lukasa
Reviewer: hawkowl
Fixes: #8317

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47343 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…il._getDeprecationSuppression.

Author: adiroiban
Reviewer: glyph
Fixes: #6266

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47345 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Author: mithrandi
Reviewer: adiroiban
Fixes: #8315

Some of the constant names had spaces, so the fallback was always used.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47355 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…lib logging.

Author: mithrandi
Reviewer: adiroiban
Fixes: #8316

Exceptions weren't logged at all; now they are.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47357 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…ectly on TLS connections

Author: lukasa
Reviewer: hawkowl
Fixes: #8318

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47359 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
…e the scripts that are run in subprocesses

Author: hawkowl
Reviewer: adiroiban
Fixes: #8266

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@47362 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
@glyph glyph mentioned this pull request May 9, 2016
@hawkowl
Copy link
Member

hawkowl commented May 15, 2016

Since this is "from" trunk, it's screwing with some of our tools :(
I'll remake for non-trunk.

@hawkowl hawkowl closed this May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants