[#8761] dist3 blacklist #501
Conversation
|
|
||
| Only necessary while parts of Twisted are unported. | ||
|
|
||
| @var modules: A list of modules that have been ported, |
There was a problem hiding this comment.
This variable doesn't exist any more.
Current coverage is 91.12% (diff: 100%)@@ trunk #501 diff @@
==========================================
Files 831 808 -23
Lines 144905 144028 -877
Methods 0 0
Messages 0 0
Branches 13574 13492 -82
==========================================
- Hits 131816 131246 -570
+ Misses 10860 10508 -352
- Partials 2229 2274 +45
|
|
Looks OK, merge it. |
| notPortedModules = [ | ||
| "twisted.conch.tap", | ||
| "twisted.conch.ttymodes", | ||
| "twisted.internet._ssl", |
There was a problem hiding this comment.
This file no longer exists and should be removed.
There was a problem hiding this comment.
More importantly - there should probably be some checking for this condition; if any of the files don't exist a test should probably fail.
There was a problem hiding this comment.
There is: https://github.com/twisted/twisted/pull/501/files/9535a4069979e35226c6a3a329bd154f1c586604#diff-8df27befe87e3feb795ca53f050639a5L29 -- we removed this file a few hours ago and I haven't merged forward. :)
There was a problem hiding this comment.
Hooray :). In that case it wouldn't be able to land if this wasn't fixed anyway; awesome.
twisted/twisted#501 pull request has changed the dist3 module. with this patch, the depgraph works again. known issue : some module with __init__ are displayed as not ported, but they are :/
https://twistedmatrix.com/trac/ticket/8761