Fix parsing of EC keys #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes printing out EC keys.
This fixes printing of EC keys, where the 'curve' attribute is of type bytes, not of type int.
We cannot just do Key._fromString_BLOB() which does getMP(blob, 2) and expects that the x,y will be the EC point. From https://tools.ietf.org/html/rfc5656#section-3.1, "point compression MAY be used". This eliminates an exception "ValueError: Invalid EC Key Y point." when parsing EC keys. This fix was submitted by glyph.
|
Oops, looks like a pretty platform-independent test failure :) |
|
Needs more work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/8931