Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to Git instead of Subversion in documentation #62

Closed
wants to merge 1 commit into from
Closed

Refer to Git instead of Subversion in documentation #62

wants to merge 1 commit into from

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented May 17, 2016

No description provided.

@adiroiban
Copy link
Member

Thanks for the contribution.

PR are not yet a accepted. See #61

You can host the code in github but please create a ticket inside Trac and ask for a review of that ticket

@adiroiban
Copy link
Member

@rodrigc
Copy link
Contributor Author

rodrigc commented May 17, 2016

@glyph @adiroiban @hawkowl @mithrandi
I followed https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch

Maybe the text there needs to be changed so that a ticket is created before the pull request is done?
That way the ticket can be referred to in the pull request itself.

If you wish to ignore certain files use the ``global-ignores`` feature of ``~/.subversion/config``, for example:

.. code-block:: console
If you wish to ignore certain files, create a ``~/.gitconfig`` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a .gitignore, which is reasonable to add things to.

@rodrigc
Copy link
Contributor Author

rodrigc commented May 17, 2016

OK, I incorporated all your changes.

@hawkowl
Copy link
Member

hawkowl commented May 17, 2016

Thanks, I've pulled your changes onto the branch listed on https://twistedmatrix.com/trac/ticket/8335.

@hawkowl hawkowl closed this May 17, 2016
@rodrigc
Copy link
Contributor Author

rodrigc commented May 18, 2016

Nice! Am I the first person to have successfully submitted to Twisted via GitHub pull request: 7593887 ?

@hawkowl
Copy link
Member

hawkowl commented May 18, 2016

@rodrigc yes ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants