Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS names are case insensitive #63

Merged
merged 6 commits into from
May 25, 2016

Conversation

zaheerm
Copy link
Contributor

@zaheerm zaheerm commented May 21, 2016

No description provided.

@rodrigc
Copy link
Contributor

rodrigc commented May 21, 2016

@zaheerm
This pull request will not be reviewed or accepted unless you follow the process at
https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch
and file a ticket.

@zaheerm
Copy link
Contributor Author

zaheerm commented May 21, 2016

Thanks @rodrigc I have now filed: https://twistedmatrix.com/trac/ticket/8343

@rodrigc
Copy link
Contributor

rodrigc commented May 21, 2016

@zaheerm thanks for following the process

@adiroiban
Copy link
Member

copy paste from https://twistedmatrix.com/trac/ticket/8343#comment:1

Many thanks for you contribution.

  1. All new changes require updated test to make sure we don't end up with regression and the test should document the intended behaviour.
  2. Also, since this is an ugly bug, it would be nice if this will be advertised in the release notes of the next release. To prevent merge conflict release notes are broken into fragments. For more details see ​http://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles

Please update your branch and resubmit for review.

Many thanks again!

@zaheerm
Copy link
Contributor Author

zaheerm commented May 21, 2016

Updated and resubmitted for review. Thanks @adiroiban

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants