In hasHostKey(), check the host key type when parsing ~/.ssh/known_hosts #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have an ecdsa-nistp-256 key in known_hosts, but the server offers an ssh-rsa key, this will cause conch to skip the entry instead of raising a bad host key error.
but the hostname + keyType is the same.
Current coverage is 91.18% (diff: 100%)@@ trunk #640 diff @@
==========================================
Files 836 813 -23
Lines 146375 145464 -911
Methods 0 0
Messages 0 0
Branches 12983 12878 -105
==========================================
- Hits 133412 132639 -773
+ Misses 10724 10560 -164
- Partials 2239 2265 +26
|
|
@the0id please review this |
|
Moved to #642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/8957