Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tox environment for downstream testing #710

Closed
wants to merge 5 commits into from
Closed

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Feb 17, 2017

At the moment, treq is the only downstream project tested.
And it is failing.
(Not a coincidence. ;)
@codecov-io
Copy link

codecov-io commented Feb 17, 2017

Codecov Report

Merging #710 into trunk will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            trunk     #710      +/-   ##
==========================================
+ Coverage   89.99%   91.26%   +1.27%     
==========================================
  Files         841      844       +3     
  Lines      146544   147605    +1061     
  Branches    12848    13061     +213     
==========================================
+ Hits       131884   134718    +2834     
+ Misses      12291    10643    -1648     
+ Partials     2369     2244     -125

@rodrigc
Copy link
Contributor

rodrigc commented Feb 18, 2017

I would say instead of calling it downstream, just call it treq. Each time you add a new downstream build, just call it what you are testing.

Be warned that Travis can get overloaded, so adding more builds there should be done with
caution.
Adding builds like this to the buildbot cluster and making them "required" for the overall build to succeed may be more manageable in terms of overall resources.

Copy link
Member

@hawkowl hawkowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't gate the build right now, as it does fail. The external state concern of mine is secondary. I think, make it non-dependent on passing for now (with the regression fix moving it out of allowed-failures), and merge.

.travis.yml Outdated
@@ -48,6 +48,8 @@ matrix:
env: TOXENV=txchecker-travis-required
- python: 2.7
env: TOXENV=txchecker-travis-all
- python: 2.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not make Treq able to fail the build; it relies on external websites (httpbin?) for its integration testing. Of course, that hasn't been an issue on treq development, so... use your discretion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should get rid of that particular misfeature of treq's CI?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glyph Maybe. I don't know how we'll do that in the short term, though :)

@glyph
Copy link
Member

glyph commented Sep 19, 2019

Closing PR due to staleness and merge conflicts.

@glyph glyph closed this Sep 19, 2019
@glyph glyph deleted the 9042-ci-for-treq branch September 19, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants