-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tox environment for downstream testing #710
Conversation
At the moment, treq is the only downstream project tested. And it is failing. (Not a coincidence. ;)
Codecov Report
@@ Coverage Diff @@
## trunk #710 +/- ##
==========================================
+ Coverage 89.99% 91.26% +1.27%
==========================================
Files 841 844 +3
Lines 146544 147605 +1061
Branches 12848 13061 +213
==========================================
+ Hits 131884 134718 +2834
+ Misses 12291 10643 -1648
+ Partials 2369 2244 -125 |
|
I would say instead of calling it Be warned that Travis can get overloaded, so adding more builds there should be done with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shouldn't gate the build right now, as it does fail. The external state concern of mine is secondary. I think, make it non-dependent on passing for now (with the regression fix moving it out of allowed-failures), and merge.
.travis.yml
Outdated
| @@ -48,6 +48,8 @@ matrix: | |||
| env: TOXENV=txchecker-travis-required | |||
| - python: 2.7 | |||
| env: TOXENV=txchecker-travis-all | |||
| - python: 2.7 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not make Treq able to fail the build; it relies on external websites (httpbin?) for its integration testing. Of course, that hasn't been an issue on treq development, so... use your discretion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should get rid of that particular misfeature of treq's CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glyph Maybe. I don't know how we'll do that in the short term, though :)
|
Closing PR due to staleness and merge conflicts. |
https://twistedmatrix.com/trac/ticket/9042