Constants in ALL_CAPS shouldn't be reported as errors.

[adiroiban]

For example MAX_LENGTH.

---

Imported from Launchpad using lp2gh.

• date created: 2013-07-12T16:29:06Z
• owner: tom.prince
• the launchpad url was https://bugs.launchpad.net/bugs/1200696

[adiroiban]

I have converted this issue into a pull request... let me know if you prefer to have separate pull requests for an issue.

---

Now the initial issue report is brief.

twistedchecker does not report ALL_CAPS constants as error... it only does so when the constants are not used in a constant like context, ie instance attribute context.

For example in twisted/protocols/amp.py I see

    def proto_value(self, string):
        """
        String received in the 'value' state.
        """
        self._currentBox[self._currentKey] = string
        self._currentKey = None
        self.MAX_LENGTH = self._MAX_KEY_LENGTH
        return 'key'

I have extended the attribute regex to allow for all caps names.

To check how pylint works I have also tried to replace "self" with "me" and it looks like in this case instance member are no longer detected as being attributes.

Please take a looks and see if this make sense.

Thanks!

[glyph]

Once again, looks good.