This repository was archived by the owner on Jan 25, 2025. It is now read-only.
fix: add support for Web Worker#270
Merged
marcandrews merged 1 commit intotwitch-js:nextfrom Dec 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## next #270 +/- ##
===================================
Coverage 98% 98%
===================================
Files 25 25
Lines 1277 1277
Branches 246 247 +1
===================================
Hits 1250 1250
Misses 26 26
Partials 1 1 Continue to review full report at Codecov.
|
marcandrews
suggested changes
Dec 25, 2020
Member
marcandrews
left a comment
marcandrews
left a comment
There was a problem hiding this comment.
Looks great 🐬
Please rename the commit and PR title to Bugfix: add support for Web Worker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"window" prevents fetch and FormData to work in a service and web worker context.