Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onContext returns light when it should be dark #13

Closed
BarryCarlyon opened this issue Dec 9, 2019 · 12 comments
Closed

onContext returns light when it should be dark #13

BarryCarlyon opened this issue Dec 9, 2019 · 12 comments
Labels
product: extensions ticketed Has been given an internal tracking ticket

Comments

@BarryCarlyon
Copy link
Contributor

BarryCarlyon commented Dec 9, 2019

Brief description

If you have a cookieless session
Then login to Twitch
And your Twitch is dark mode
Then open a ext configuration panel, that configuration panel is onContext passed "light" instead of dark.

How to reproduce

  1. Delete all the cookies/chrome incognito etc
  2. Login to Twitch
  3. If you Twitch is auto dark mode (from browser detect or otherwise)
  4. Open a configuration panel for an extension
  5. Marvel in how bright the configuration panel is in error

Expected behavior

It be dark

Screenshots

image

@billygerhard
Copy link

I am getting this error on a panel as well, it isn't limited to the configuration page.

@BarryCarlyon
Copy link
Contributor Author

Issue confirmed also on front end with a "full" video extension.

Same repeat steps

Login, open an extension

Screenshot 2019-12-27 at 20 37 36

@jbulava
Copy link
Member

jbulava commented Jan 24, 2020

Tracking internally on EXT-1151.

@marcandrews
Copy link

I'm experiencing this on the config view, but not on the video overlay view.

@jbulava jbulava added the ticketed Has been given an internal tracking ticket label Feb 12, 2020
@ricardjorg
Copy link

image
I also get that on the live config view. The twitch theme is dark, but the theme I get from the context is the light one

@TristanWiley
Copy link

This should now be resolved! 👍

@Djiit
Copy link

Djiit commented Jun 23, 2020

Working like a charm !
image

@BarryCarlyon
Copy link
Contributor Author

I ran the repeat steps. Seems ok!

@BarryCarlyon
Copy link
Contributor Author

UPDATED: onContext is now NOT FIRING when you change from dark/light mode.

It's only firing at page load!

REOPEN THE ISSUE @TristanWiley

@jbulava
Copy link
Member

jbulava commented Jun 29, 2020

Tristan's on it. He created a new ticket for this on ANC-2398.

@roikoren755
Copy link

Testing my extension, I see onContext fired a lot when the channel is live and streaming, which is great.
However, I still do not see it fired when changing the theme, or as soon as the channel goes offline and the video stops.

@lleadbet
Copy link
Contributor

lleadbet commented Sep 9, 2020

As an update, this should be resolved now.

@lleadbet lleadbet closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: extensions ticketed Has been given an internal tracking ticket
Projects
None yet
Development

No branches or pull requests

9 participants