Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onContext not sending any video data (eg: hls delay) when ONLY a panel is active on the channel #284

Open
BarryCarlyon opened this issue Jan 6, 2021 · 4 comments
Labels
product: extensions ticketed Has been given an internal tracking ticket

Comments

@BarryCarlyon
Copy link
Contributor

BarryCarlyon commented Jan 6, 2021

Brief description

onContext is very "dry"/lacking details

If there is no extension active in the video slot.

How to reproduce

https://gist.github.com/BarryCarlyon/71c15dc7f82f28ef5c59064be74e065a

See also #233

Expected behavior

Hydrated data in the onContext callback

Screenshots

Left, 3 months ago.
Right, right now.

Same code, (It's possible in the 3 month ago test, I had a video extension active for testing)

image

With any video extension acitve

image

Without

image

Additional context or questions

Original report

https://discuss.dev.twitch.tv/t/oncontext-hlslatencybroadcaster-not-working-in-local-hosted-test/29795/

@BarryCarlyon BarryCarlyon changed the title onContext not sending any video data with being a panel onContext not sending any video data (eg: hls delay) when ONLY a panel is active on the channel Jan 6, 2021
@lleadbet
Copy link
Contributor

Ticketed internally as ANC-2708.

@lleadbet lleadbet added the ticketed Has been given an internal tracking ticket label Jan 19, 2021
@jbulava
Copy link
Member

jbulava commented Oct 27, 2021

Missed closing this out. The internal ticket to resolve this issue was deployed in March. If the issue persists though, please let us know.

@jbulava jbulava closed this as completed Oct 27, 2021
@BarryCarlyon
Copy link
Contributor Author

BarryCarlyon commented Oct 28, 2021

Nothing has changed it is still broken.
The behaviour observed today is unchanged from the original report

please reopen this issue

I've sent you a video to review

@jbulava jbulava reopened this Oct 28, 2021
@byte2pixel
Copy link

I'm currently writing an extension and nearly ready to submit but this issue seems to be holding me up. My extension is game specific and one of the settings the streamer can set is if the extensions functionality should be available

  • All the time
  • Only when playing the game
  • Off

However I am seeing that whenever the stream is started and the game is left the same as it was from previous streams the onContext call always returns game: "" I left the stream on for over 30 minutes and even new browsers on different networks were reporting the same data in onContext and the game was just an empty string.

However I the broadcaster changed games while live onContext fired the callback with the new game. Then switching back to the previous game fired it again with the original game which would then activate my extension when the settings were set to "Only when playing the game"

It's sad that I am here 2 years later facing the same issue. I'm not sure how to go about handling this. I guess I can treat an empty string as being the correct game and only treat strings that are not empty as being some other game if they don't match the game my extension is for.

Basically "empty string" or "the game" = THE GAME
else NOT THE GAME.

Any better solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: extensions ticketed Has been given an internal tracking ticket
Projects
None yet
Development

No branches or pull requests

4 participants