Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bits leaderboard should error if no started_at but period #298

Closed
BarryCarlyon opened this issue Jan 29, 2021 · 1 comment
Closed

Bits leaderboard should error if no started_at but period #298

BarryCarlyon opened this issue Jan 29, 2021 · 1 comment
Labels
product: api API endpoints in the "helix" namespace

Comments

@BarryCarlyon
Copy link
Contributor

Brief description

The Bits Leaderboard says that if you use a period of not all you need to specify a started_at if you don't specify a started_at then it doesn't error it just returns no data.

How to reproduce

Call https://api.twitch.tv/helix/bits/leaderboard?count=2&period=week and get no data

Call https://api.twitch.tv/helix/bits/leaderboard?started_at=2021-01-29T00:00:00Z&period=week&count=2 and get data.

The former should error indicating the missing started_at

Expected behavior

If you specify a period and no started_at return an error

Additional context or questions

https://discuss.dev.twitch.tv/t/issue-with-curl-query-for-bits-leaderboard/30201

@BarryCarlyon BarryCarlyon added the product: api API endpoints in the "helix" namespace label Jan 29, 2021
@scott-a-white
Copy link

Thanks Barry for the feedback. Going to close this since it looks like the code has been fixed and the doc update will go out in this week's build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: api API endpoints in the "helix" namespace
Projects
None yet
Development

No branches or pull requests

2 participants