Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnContext not called when video component extension is activated #513

Open
Breci opened this issue Oct 15, 2021 · 5 comments
Open

OnContext not called when video component extension is activated #513

Breci opened this issue Oct 15, 2021 · 5 comments

Comments

@Breci
Copy link

Breci commented Oct 15, 2021

Brief description
When an extension is just installed, onContext is called, when you activate it on a video component slot. It is not called anymore

Reproduced in viewer / config / dashboard views

How to reproduce

Create an extension with the onContext callback set up, install it, open the config, see the logs from onContext, activate it, refresh the config, no logs anymore

Expected behavior

OnContext should be always called

@BarryCarlyon
Copy link
Contributor

Likely related to #284 (or would have the same fix Twitch side)

Also do you get differing behaviour when the channel is live/not live?

@Breci
Copy link
Author

Breci commented Oct 17, 2021

Both in my case.
I noticed for the video component because the review team failed a review because the extension didn't load because of that bug
And I tested the configuration on both, and the dashboard when it was live only.

@cloutship
Copy link

Yep, same behavior on our end. The channel being live/not live doesn't make a difference. Only thing that changes is if you deactivate the extension or set it to something other than a video component.

@Zozman
Copy link

Zozman commented Jan 23, 2022

I'm seeing the issue as well. It works after initialization when the theme is changed but can't get the theme when first starting the extension.

@BarryCarlyon
Copy link
Contributor

BarryCarlyon commented Feb 25, 2022

Also likely related to #35

Having test this, this morning, I got onContext data if I open, close, and open the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants