Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control PubSub stops listening/Extension config won't change on frontend #62

Open
BarryCarlyon opened this issue Feb 19, 2020 · 6 comments
Labels
product: extensions ticketed Has been given an internal tracking ticket

Comments

@BarryCarlyon
Copy link
Contributor

BarryCarlyon commented Feb 19, 2020

Brief description

The following two PubSub topics pertaining to extensions don't like to reconnect

  • Twitch Extension pubsub.
  • Twitch Extension control pubsub.

The former:

https://dev.twitch.tv/docs/extensions/reference#helper-extensions

The listen events described there

And the latter:

The Extension Control pubsub, the one that live changes what extensions are active on a give stream.

Both of these topics, are not "reconnect" safe on the main Twitch PubSub.

Resulting in the wrong extensions being loaded, or extensions no longer receiving PubSub broadcasted events

How to reproduce

Leave a Twitch stream open for an amount of time.

Today's issue occured on itmeJP's channel after about 30 minutes. The loaded extension stopped receiving PubSub broadcasted events.

Expected behavior

Whenever Twitch "main" pubsub reconnects, or whatever, reconnect the extension control and extension listen topics.

Additional context or questions

It's both an extensions issue and a main website issue.
It's unclear what can cause the main Twitch pubsub feed to die.

@BarryCarlyon
Copy link
Contributor Author

Additional Example:

Cohh was live with "CohhVideo" loaded in the video Slot
He goes offline
I switched the live extensions as follows

  • No extension loaded
  • DF extension loaded
    (Two seperate API requests)

Cohh goes live for DF, CohhVideo showed as in the slot for me, instead of what was selected. As my browser has DC'ed the control topics.

@BarryCarlyon
Copy link
Contributor Author

Whatever is happening also seems to effect the title/game auto updates beneath a stream

@mauerbac mauerbac added the ticketed Has been given an internal tracking ticket label Mar 23, 2020
@mauerbac
Copy link

EXT-1157

@BarryCarlyon BarryCarlyon changed the title Extensions stop listening to PubSub Control PubSub stops listening Mar 25, 2020
@BarryCarlyon
Copy link
Contributor Author

Consider this graph

image

This extension is only active on a Wednesday afternoon.

But due to this bug, a twitch player will not update title, game information automatically (without a reload), AND will not update the active extensions. So a user may have a page open with a stream open, and it stops listening to all real time updates for all data.

This also affects the extension pubsub service inside an extension.

Just another way to display the issue

@BarryCarlyon
Copy link
Contributor Author

Or this one

Video extension: the spike is stream up.
I switched off the left extension and turned on the right extension.

image

But still 600 people loaded the wrong extension at stream up, as 600 people has Disconnected from the control pubsub (for title, game and extension real time updates)

@BarryCarlyon
Copy link
Contributor Author

Today

Streamer changed extensions in the video slot using the dashboard. (config b)
I was stuck with the previous configuration (config a)

Reload the page, right config (config b active)

Fast forward 3 1/2 hours or so

I changed the extensions on the same channel to the previous configuration/what was active in the video slot
I was stuck with the (config b) again
Instead of seeing config A again, I'm seeing config b

Reload I get config A as expected

Today this was in Safari.
Laptop did not go to sleep.

Issue is present across browsers

@BarryCarlyon BarryCarlyon changed the title Control PubSub stops listening Control PubSub stops listening/Extension config won't change on frontend Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: extensions ticketed Has been given an internal tracking ticket
Projects
None yet
Development

No branches or pull requests

2 participants