Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for the content type header issue #140

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

BarryCarlyon
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

This fixes #138

Description of Changes:

  • parse the content type header using the mime library
  • test the content type when present
  • report the charset if a charset is returned in the content-type header

Example output:

✔ Valid response. Received challenge [omitted] in body
✔ Valid content-type header. Received type text/plain with charset utf-8
✔ Valid status code. Received status 200

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@vpolouchkine vpolouchkine merged commit e761829 into twitchdev:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot test event verify because an unspecified Content-Type is expected
2 participants