Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client option for literal URLs #277

Merged
merged 5 commits into from Sep 25, 2020

Conversation

ofpiyush
Copy link
Contributor

Issue #, if available:
#244 , #257

Description of changes:
Adds a new client option to use literal URLs instead of the default CamelCased ones.

The updated test in internal/twirptest/snake_case_names covers behaviour of both the client and the server.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ofpiyush
Copy link
Contributor Author

@marioizquierdo I am not 100% sure on the name for the public method WithClientLiteralCase. If you have a better one, I'd be happy to change it.

Other than that, this PR is ready to merge

@marioizquierdo
Copy link
Contributor

I'm adding a patch to get it ready. We just conflicted merging from master at the same time heh. Will be ready in a few minutes and I'll merge. Thanks fro this work!

@marioizquierdo
Copy link
Contributor

Updated to keep the client implementation with a single list of urls (instead of having two lists), and when the Service and Method names are already CamelCased (like most examples in tests) keep the exact same generated code.

@marioizquierdo marioizquierdo merged commit dd6c41b into twitchtv:master Sep 25, 2020
@ofpiyush ofpiyush deleted the client_compat branch September 25, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants