From 03cdfbb6b0a7a549ed69f228bae90569a0cfc585 Mon Sep 17 00:00:00 2001 From: eaceaser Date: Tue, 5 Oct 2010 18:40:23 -0700 Subject: [PATCH] w3c: add configurablity whine on unregistered fields --- src/main/scala/com/twitter/ostrich/W3CStats.scala | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/scala/com/twitter/ostrich/W3CStats.scala b/src/main/scala/com/twitter/ostrich/W3CStats.scala index 9635de61..a8500a68 100644 --- a/src/main/scala/com/twitter/ostrich/W3CStats.scala +++ b/src/main/scala/com/twitter/ostrich/W3CStats.scala @@ -30,11 +30,10 @@ import java.text.SimpleDateFormat * * @param fields The fields, in order, as they will appear in the final w3c log output. */ -class W3CStats(reporter: W3CReporter, fields: Array[String]) extends StatsProvider { - def this(logger: Logger, fields: Array[String]) = this(new W3CReporter(logger), fields) +class W3CStats(reporter: W3CReporter, fields: Array[String], complainAboutUnregisteredFields: Boolean) extends StatsProvider { + def this(logger: Logger, fields: Array[String]) = this(new W3CReporter(logger), fields, true) val log = Logger.get(getClass.getName) - var complainAboutUnregisteredFields = true val fieldNames: java.util.HashSet[String] = new java.util.HashSet() fields.foreach { fieldNames.add(_) } @@ -63,8 +62,9 @@ class W3CStats(reporter: W3CReporter, fields: Array[String]) extends StatsProvid private def log_safe[T](name: String, value: T) { if (complainAboutUnregisteredFields && !fieldNames.contains(name)) { log.error("trying to log unregistered field: %s".format(name)) + } else { + get + (name -> value) } - get + (name -> value) } /**