Should right mouse click on table view select the cell? #37

Closed
brutella opened this Issue Aug 6, 2011 · 8 comments

Comments

Projects
None yet
4 participants
@brutella
Contributor

brutella commented Aug 6, 2011

The right mouse click events are mostly used to show context menus based on underlying cell. Therefore I think the cell should also be selected when right clicking on the cell.

In the current implementation the cell is only selected when left clicking on the cell.

@Naituw

This comment has been minimized.

Show comment Hide comment
@Naituw

Naituw Aug 6, 2011

You can make it a optional delegate method

Naituw commented Aug 6, 2011

You can make it a optional delegate method

@brutella

This comment has been minimized.

Show comment Hide comment
@brutella

brutella Aug 6, 2011

Contributor

Right, would be a nice solution!

Contributor

brutella commented Aug 6, 2011

Right, would be a nice solution!

@atebits

This comment has been minimized.

Show comment Hide comment
@atebits

atebits Aug 6, 2011

Contributor

works for me, but one change - method should be of the form: -(BOOL)tableViewShouldSelectRowOnRightClick:(TUITableView *)tableView;

Contributor

atebits commented Aug 6, 2011

works for me, but one change - method should be of the form: -(BOOL)tableViewShouldSelectRowOnRightClick:(TUITableView *)tableView;

@omz

This comment has been minimized.

Show comment Hide comment
@omz

omz Aug 6, 2011

I think it would be even better if the delegate method also included the indexPath that is about to be selected. It might be desirable to have a different behavior for different rows.

omz commented Aug 6, 2011

I think it would be even better if the delegate method also included the indexPath that is about to be selected. It might be desirable to have a different behavior for different rows.

@atebits

This comment has been minimized.

Show comment Hide comment
@atebits

atebits Aug 6, 2011

Contributor

Totally.

Contributor

atebits commented Aug 6, 2011

Totally.

@brutella

This comment has been minimized.

Show comment Hide comment
@brutella

brutella Aug 6, 2011

Contributor

We could make a more generic method where a selection can be restricted based on the event.

For example: - (BOOL)tableView:(TUITableView*)tableView shouldSelectRowAtIndexPath:(TUIFastIndexPath*)indexPath forEvent:(NSEvent*)event;

Contributor

brutella commented Aug 6, 2011

We could make a more generic method where a selection can be restricted based on the event.

For example: - (BOOL)tableView:(TUITableView*)tableView shouldSelectRowAtIndexPath:(TUIFastIndexPath*)indexPath forEvent:(NSEvent*)event;

@atebits

This comment has been minimized.

Show comment Hide comment
@atebits

atebits Aug 6, 2011

Contributor

Sweet, yeah.

Contributor

atebits commented Aug 6, 2011

Sweet, yeah.

@brutella

This comment has been minimized.

Show comment Hide comment
@brutella

brutella Aug 9, 2011

Contributor

Pull request #38 merged. Done!

Contributor

brutella commented Aug 9, 2011

Pull request #38 merged. Done!

@brutella brutella closed this Aug 9, 2011

adib pushed a commit to adib/twui that referenced this issue Aug 7, 2012

Merge pull request #37 from github/fix-nsview-flippedness
Handle -[NSView isFlipped] when rendering the rootView of a TUIViewNSViewContainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment