Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting 'data-toggle' be preferred over 'rel' in tooltip/popover usage #3031

Closed

Conversation

BigBlueHat
Copy link
Contributor

This is a documentation-focused commit. The first commit message contains more info--copy/pasted below for "usability":

data-toggle is consistently used throughout Bootstrap for
toggling UI related content. The rel attribute is also
intended for expressing the relationship between the current
URL and the URL being linked to.

In addition (and the initial motiviation for this change),
the HTML5 validator [1] marks the HTML as invalid for using
unregistered rel values.

[1] http://validator.w3.org/

Thanks for considering this change.

data-toggle is consistently used throughout Bootstrap for
toggling UI related content. The rel attribute is also
intended for expressing the relationship between the current
URL and the URL being linked to.

In addition (and the initial motiviation for this change),
the HTML5 validator [1] marks the HTML as invalid for using
unregistered rel values.

[1] http://validator.w3.org/
@ctalkington
Copy link
Contributor

I agree with this change, even tipsy uses a custom attribute over rel and consistent naming is a plus.

@ctalkington
Copy link
Contributor

you may want to consider doing your changes on 2.0.3-wip branch and resubmitting. it makes it hard to merge in changes if they are based on non-dev branch. 2.0.3 has quite a few changes from 2.0.2.

@BigBlueHat
Copy link
Contributor Author

Good point. I've been branching off of master, but can change that habit if it's best for pull-requests to be based off the newest wip branch.

It's easy enough to rebase these. Just let me know.

@fat
Copy link
Member

fat commented Apr 15, 2012

yep - please reopen against 2.0.3. I think this is a great patch :)

@fat fat closed this Apr 15, 2012
@danielcha
Copy link

As far as I can tell this patch never got resubmitted? And I think it should :-)

As I am still new to Github I don't know how to go about resubmitting this patch. Can someone please resubmbit this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants