Skip to content

Dropdown Touch Bug Fix#6064

Closed
marcopeg wants to merge 1 commit into
twbs:masterfrom
marcopeg:master
Closed

Dropdown Touch Bug Fix#6064
marcopeg wants to merge 1 commit into
twbs:masterfrom
marcopeg:master

Conversation

@marcopeg

Copy link
Copy Markdown

On touch device you are able to open a drop down but not to select a value inside it!

This line fix the problem and here you can read about this error and it's solution:
http://movableapp.com/2012/11/twitter-bootstrap-dropdown-bugfix

On touch device you are able to open a drop down but not to select a
value inside it.

This line fix the problem and here you can read about this error and
it's solution:
http://movableapp.com/2012/11/twitter-bootstrap-dropdown-bugfix/
@blakeembrey

Copy link
Copy Markdown
Contributor

You do realise you have made this PR against master - because the binding of events in 2.2.2-wip is to the document.

@mdo

mdo commented Nov 30, 2012

Copy link
Copy Markdown
Member

Closing per @blakeembrey's comment.

@mdo mdo closed this Nov 30, 2012
@marcopeg

Copy link
Copy Markdown
Author

I'm not sure to understand you.
Mi code works booth on 2.2.1 and 2.2.2, none of them works on touch devices without this PR.

I have my iPhone in my hands and tested it in a lot of situations where drop down are requested!

@blakeembrey

Copy link
Copy Markdown
Contributor

It might work on both 2.2.1 and 2.2.2, but you are working against old code not to mention you shouldn't open a pull request against master - only *-wip branches. Take a look in the code for 2.2.2-wip or even look at someone elses solution - a lot of people have already submitted this issue and even made other pull requests with similar fixes.

@marcopeg

marcopeg commented Dec 1, 2012

Copy link
Copy Markdown
Author

... oook, so I really can't understand why you don't want to fix this little bug.. I know a big update to the dropdown widget is next to be released but, by now, I can't get my project works the right way without to hack TB core!

Just tell me why!

NOTICE: This PR, and may be others, proposes a quick fix to allow our (the community) to use the good TB with all it's power!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants