Permalink
Commits on May 18, 2017
  1. Upgrade to pants 1.3.0rc1 (#451)

    * Upgrade to 1.3.0rc1
    * Remove dead target, and fix argument ordering in ci.sh
    * Enable storing the buildcache in travis` cache.
    * Merge JVM target sets, drop a bunch of unnecessary test aliases.
    * Drop remote_python_thrift_fileset, fix resource definitions.
    * Clear RootMetrics (singleton... yuck) before use, and skip flaky test.
    stuhood committed on GitHub May 18, 2017
Commits on Apr 7, 2017
  1. Bump pants to 1.3.0.dev14 and fix deprecation warnings (#449)

    ### Problem
    
    The 1.2.1 upgrade was incomplete, and didn't update the ci.sh script for python.
    
    ### Solution
    
    Bump to a newer version, allow prerelease python dependencies, raise the python version constraint, and remove deprecated flags.
    stuhood committed on GitHub Apr 7, 2017
Commits on Apr 6, 2017
  1. Update to pants 1.2.1 (#448)

    ### Problem
    
    commons is on a >1 year old, pre-`1.0.0` version of pants.
    
    ### Solution
    
    Updated to the latest stable version and got the majority of the tests passing.
    stuhood committed on GitHub Apr 6, 2017
Commits on Dec 2, 2016
  1. Drop rbcommons in favor of github reviews. (#446)

    ### Problem
    
    Twitter has decided to move away from RBCommons for external contributions, at least partially because of the improvements to Github reviews... but also due to a unanimous decision from the pantsbuild/pants project to move away from RBCommons as well (the largest project that was using rbcommons).
    
    ### Solution
    
    Update documentation and scripts to describe a Github-pull-request-based workflow.
    
    ### Result
    
    All future review should be accomplished via Github pull requests.
    stuhood committed on GitHub Dec 2, 2016
Commits on Nov 8, 2016
  1. docs: updated broken link

    maheshgaya committed with Yasumoto Nov 7, 2016
Commits on Oct 14, 2016
  1. Bump Version to 0.3.9

    BobbyD-FL committed with kwlzn Oct 14, 2016
  2. Fix inverted existence check for hdfs/hadoop command

    twitter.commons.fs.hdfs was broken by https://rbcommons.com/s/twitter/r/4302/ - When checking for the 'hdfs' or 'hadoop' commands, if the command exists in the path the not-found exception is raised. Instead, the if statement needs to be inverted
    
    Testing Done:
    Travis build: https://travis-ci.org/twitter/commons/builds/167725210
    
    Bugs closed: 442
    
    Reviewed at https://rbcommons.com/s/twitter/r/4308/
    Michael Leinartas committed with kwlzn Oct 14, 2016
  3. Bump Version to 0.3.8

    BobbyD-FL committed with kwlzn Oct 14, 2016
Commits on Oct 13, 2016
  1. Added CommandUtil.cmd_within_path() within twitter.common.util.comman…

    …d_util and patched twitter.common.fs.hdfs
    
    Testing Done:
    Travis: https://travis-ci.org/twitter/commons/builds/167214107
    
    Bugs closed: 440
    
    Reviewed at https://rbcommons.com/s/twitter/r/4302/
    BobbyD-FL committed with kwlzn Oct 13, 2016
Commits on Aug 15, 2016
  1. Bump VERSION

    kwlzn committed on GitHub Aug 15, 2016
  2. Fix AttributeError in HDFSHelper constructor (#436)

    use_hadoop_v1 isn't a member variable. 
    #435
    chickenbellyfinn committed with kwlzn Aug 15, 2016
Commits on Jul 22, 2016
  1. Bump VERSION to 0.3.6.

    Bugs closed: 434
    
    Reviewed at https://rbcommons.com/s/twitter/r/4109/
    drewrothstein committed with kwlzn Jul 22, 2016
Commits on Jul 18, 2016
  1. [hadoop] change hadoop to hdfs cli

    [hadoop] add v1 option but default to hdfs
    
    GitHub: #433/
    
    Testing Done:
    Travis: https://travis-ci.org/twitter/commons/builds/141925751
    
    Updated Travis: https://travis-ci.org/twitter/commons/builds/143485107
    
    Bugs closed: 433
    
    Reviewed at https://rbcommons.com/s/twitter/r/4048/
    drewrothstein committed with kwlzn Jul 18, 2016
Commits on May 13, 2016
  1. Merge pull request #426 from atollena/endpoint-ip-addresses

    python: Add IP addresses to serverset entries
    atollena committed May 13, 2016
  2. python: Add IP addresses to serverset entries

    ServerSet entries contain hostnames that require a DNS lookup before
    use. When hostnames map to a unique, fixed IP address, this additional
    lookup is unnecessary and can put strain on DNS infrastructure in large
    deployments.
    
    This change adds 2 optional fields to server set endpoints: `inet` and
    `inet6` respectively for a human readable representation of an IPv4 and
    of an IPv6 address.
    
    Hostnames are still mandatory, for backward compatibility with clients
    that expect those fields. Port is untouched.
    atollena committed May 13, 2016
Commits on May 10, 2016
  1. Repair ./rbt for review posting.

    As Mateo noted in #428, `./rbt` in the commons repo seems to have been broken @ 146de3 due to removal of the underlying virtualenv bits.
    
    This RB restores the requisite venv deps and bumps both `virtualenv` and `rbtools` to their latest pypi versions to get `./rbt` functional again.
    
    Testing Done:
    Dogfooded for this very review + green CI @ https://travis-ci.org/twitter/commons/builds/129290520 for good measure.
    
    before:
    
    ```
    [illuminati commons (master)]$ ./rbt --version
    ./rbt: line 3: build-support/python/libvirtualenv.sh: No such file or directory
    ./rbt: line 4: setup_virtualenv: command not found
    ./rbt: line 6: exec: rbt: not found
    ```
    
    after:
    
    ```
    [illuminati commons (kwlzn/commons/rbt_fix)]$ ./rbt --version
    Bootstrapping rbt with requirements RBTools==0.7.6
    Using /Users/kwilson/Python/CPython-2.7.11/bin/python2.7
    ~/dev/commons/build-support ~/dev/commons
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 1799k  100 1799k    0     0  2207k      0 --:--:-- --:--:-- --:--:-- 2205k
    ...
    ~/dev/commons
    New python executable in /Users/kwilson/dev/commons/build-support/rbt.venv/bin/python2.7
    Also creating executable in /Users/kwilson/dev/commons/build-support/rbt.venv/bin/python
    Installing setuptools, pip, wheel...done.
    Collecting RBTools==0.7.6
      Using cached RBTools-0.7.6-py2-none-any.whl
    Collecting six>=1.8.0 (from RBTools==0.7.6)
      Using cached six-1.10.0-py2.py3-none-any.whl
    Installing collected packages: six, RBTools
    Successfully installed RBTools-0.7.6 six-1.10.0
    RBTools 0.7.6
    ```
    
    Reviewed at https://rbcommons.com/s/twitter/r/3858/
    kwlzn committed with kwlzn May 10, 2016
  2. Update the futures library.

    This bumps futures to a more modern version,
    some useful Python libraries are pinned to a range
    that is later than the current t.c. `futures` version.
    
    ex. boto3 is pinned to `futures>=2.2.0,<4.0.0` for python2.7
    
    This is the minimum-viable change that makes the t.c.
    libs compatible.
    
    Testing Done:
    Ran ci.sh locally and Travis passed: #428
    
    Bugs closed: 427, 428
    
    Reviewed at https://rbcommons.com/s/twitter/r/3857/
    mateor committed with kwlzn May 10, 2016
Commits on May 9, 2016
  1. [python zookeeper] Add member_id to ServiceInstance object if provided.

    Add member_id to ServiceInstance object if supplied when creating it and make that the default action when creating a serverset list. This is mostly useful for reconciling issues with the serverset e.g. duplicate registration.
    
    pull request #425
    
    Testing Done:
    https://travis-ci.org/twitter/commons/builds/127596017
    
    $ ./pants test tests/python/twitter/common/zookeeper:all
    11:22:40 00:02 [chroot]============== test session starts ===============
    platform darwin -- Python 2.7.10 -- py-1.4.31 -- pytest-2.6.4
    plugins: cov, timeout
    collected 85 items
    
                     tests/python/twitter/common/zookeeper/kazoo_client_test.py .
                     tests/python/twitter/common/zookeeper/group/test_active_kazoo_group.py ................................................
                     tests/python/twitter/common/zookeeper/group/test_kazoo_group.py ..................
                     tests/python/twitter/common/zookeeper/serverset/test_endpoint.py ............
                     tests/python/twitter/common/zookeeper/serverset/test_kazoo_serverset.py .....
                     tests/python/twitter/common/zookeeper/serverset/test_serverset_unit.py .
    
                     =========== 85 passed in 23.80 seconds ===========
    
    Reviewed at https://rbcommons.com/s/twitter/r/3814/
    Brian Rutkin committed with kwlzn May 9, 2016
Commits on Apr 26, 2016
  1. Work around lockfile break.

    This pins lockfile's pbr dep on lockfile's behalf as reccomended here:
      https://groups.google.com/d/topic/pants-devel/OnPISJosUoI/discussion
    
    Testing Done:
    CI went green here:
      https://travis-ci.org/twitter/commons/builds/125937912
    
    Bugs closed: 424
    
    Reviewed at https://rbcommons.com/s/twitter/r/3762/
    jsirois committed Apr 26, 2016
Commits on Nov 21, 2015
  1. [twitter/commons] Upgrade pants from 0.0.44 -> 0.0.59

    Upon merging an innocuous PR after 2+ months of no merges, CI broke in the commons repo due to pantsbuild/pants#2566 + the public release of pytest-timeout-1.0.0 (which is visible by commons via open dep resolution against pypi). This change addresses that by upgrading the entire commons repo to pants 0.0.59 wherein #2566 is repaired.
    
    - Upgrade pants to 0.0.59.
    - Fixup various symbol references and usages throughout.
    - Update excludes syntax.
    - Upgrade to contrib python checks plugin for PythonEval (which brings along checkstyle).
    - Implement repo-wide python checkstyle suppression due to numerous checkstyle errors in the codebase.
    - Sync out latest twitter.common.args from Twitter's source repo to support removal of apt-args plugin.
    - Eliminate the apt-args plugin, which is no longer needed with isolation.
    
    Testing Done:
    https://travis-ci.org/twitter/commons/builds/92376412
    
    Bugs closed: 414
    
    Reviewed at https://rbcommons.com/s/twitter/r/3155/
    kwlzn committed with kwlzn Nov 21, 2015
Commits on Nov 19, 2015
  1. Merge pull request #407 from johnskopis/jskopis/update-kazoo

    Upgrade kazoo 1.3.1 -> 2.2.1
    kwlzn committed Nov 19, 2015
Commits on Oct 2, 2015
  1. Merge pull request #412 from landism/master

    eliminate double slash in reviewboard urls
    orsenthil committed Oct 2, 2015
Commits on Sep 23, 2015
  1. use urljoin

    Matt Landis committed Sep 23, 2015
Commits on Sep 22, 2015
  1. eliminate double slash in reviewboard urls

    Matt Landis committed Sep 22, 2015
Commits on Aug 24, 2015
  1. Upgrade to pants 0.0.44.

    The release notes are here:
      https://pypi.python.org/pypi/pantsbuild.pants/0.0.44
    
    Of particular interest to twitter/commons is the graduation of the
    isolated jvm compile strategy to a viable out-of-the-box solution for
    java & scala compiles.  This change includes a switch over to that
    strategy which necessitated an upgrade to scala 2.10.
    
    Testing Done:
    CI went green here:
      https://travis-ci.org/twitter/commons/builds/77066466
    
    Bugs closed: 410
    
    Reviewed at https://rbcommons.com/s/twitter/r/2691/
    jsirois committed Aug 24, 2015
Commits on Aug 17, 2015
  1. Kill cruft no longer used/needed by comons.

    The 0.0.42 upgrade and switch to the standard pants bootsrap script
    killed the need for both build-support/virtualenv and
    build-support/python/libvirtualenv.sh.
    
    I also noticed build-support/ivy/ci.ivysettings.xml was unused.
    
    Testing Done:
    CI went green here:
      https://travis-ci.org/twitter/commons/builds/75838991
    
    Bugs closed: 409
    
    Reviewed at https://rbcommons.com/s/twitter/r/2641/
    jsirois committed Aug 17, 2015
Commits on Aug 16, 2015
  1. Upgrade to pants 0.0.42.

    The release notes are here:
      https://pypi.python.org/pypi/pantsbuild.pants/0.0.42
    
    This change also switches over to the standard pants setup script
    from https://pantsbuild.github.io/setup and uses the new pants
    plugins loading mechanism.  Now the pants & plugins install is
    completely controlled in pants.ini.
    
    Testing Done:
    CI went green here:
      https://travis-ci.org/twitter/commons/builds/75833044
    
    Bugs closed: 408
    
    Reviewed at https://rbcommons.com/s/twitter/r/2636/
    jsirois committed Aug 16, 2015
Commits on Aug 14, 2015
  1. Upgrade kazoo 1.3.1 -> 2.2.1

    John Skopis committed Aug 13, 2015
Commits on Aug 10, 2015
  1. Upgrade to pants 0.0.41

    The release notes are here:
      https://pypi.python.org/pypi/pantsbuild.pants/0.0.41
    
    Of note are fixes to python chroot caching which fixes behavior of
    python tasks when edits are made to a python_binary's python_library
    dependencies.
    
    Testing Done:
    CI went green here:
      https://travis-ci.org/twitter/commons/builds/74840320
    
    Bugs closed: 406
    
    Reviewed at https://rbcommons.com/s/twitter/r/2585/
    jsirois committed Aug 10, 2015
Commits on Aug 6, 2015
  1. Prepare twitter.common.pants release

    Release for pantsbuild.pants 0.0.40, which requires a new version of twitter.common.*
    
    Reviewed at https://rbcommons.com/s/twitter/r/2577/
    stuhood committed with stuhood Aug 6, 2015
Commits on Aug 4, 2015
  1. Merge pull request #395 from imsut/enrich_reviewboard

    Enrich reviewboard utility class for python
    Yasumoto committed Aug 4, 2015
  2. add spec_set=True

    imsut committed Aug 4, 2015
  3. add autospec=True

    imsut committed Aug 4, 2015