This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Update to pants 1.4.0rc0 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kwlzn
approved these changes
Jan 17, 2018
| @@ -21,14 +21,15 @@ pythonpath: [ | |||
| ] | |||
| backend_packages: +[ | |||
| 'twitter.common.pants.python.commons', | |||
| 'pants.contrib.python.checks', | |||
There was a problem hiding this comment.
Yes: Putting something in the plugin list enables it, so having this here was enabling it twice, which now causes an error.
|
As evidenced by one shard failing with a timeout at the end of pytest running, and the other not, it looks like this has nothing to do with the daemon. Regardless, will skip enabling it in this bump because I've already made enough edits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.