New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About expire time in fatcache #18

Closed
git-hulk opened this Issue Nov 26, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@git-hulk
Copy link
Contributor

git-hulk commented Nov 26, 2014

hi @manju @thinkingfish

I have some questions:

  1. why not put expire time in itemx, as we have to use it frequently, and it may lead to read disk slab.
  2. why not add stats command for fatcache, as it may be useful.

Best Regards~

@manjuraj

This comment has been minimized.

Copy link
Collaborator

manjuraj commented Dec 12, 2014

@git-hulk yeah both those suggestions make sense

@git-hulk

This comment has been minimized.

Copy link
Contributor Author

git-hulk commented Dec 13, 2014

thank you, @manjuraj
I will try to make a patch for those. by the way, why the following code is discarded, and it cause quit command unusable.
https://github.com/twitter/fatcache/blob/master/src/fc_request.c#L108

@git-hulk

This comment has been minimized.

Copy link
Contributor Author

git-hulk commented Jan 8, 2017

put the expire time to index was done, close this issue. pr: #21

@git-hulk git-hulk closed this Jan 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment