From 0c3a8a3e688c269c9b0f40b54b6def8bb1ee1abe Mon Sep 17 00:00:00 2001 From: Yawar Quadir Amin <68562631+yamin-oanda@users.noreply.github.com> Date: Wed, 1 Nov 2023 14:50:54 +0000 Subject: [PATCH] [finagle-mysql] Give NullParameter a friendly string representation Otherwise stringifying it results in random output like: `com.twitter.finagle.mysql.Parameter$NullParameter$@5550f534`. This doesn't work well with e.g. snapshot tests. Result Closes twitter/finagle#947 Differential Revision: https://phabricator.twitter.biz/D1107769 --- .../src/main/scala/com/twitter/finagle/mysql/Parameter.scala | 1 + 1 file changed, 1 insertion(+) diff --git a/finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Parameter.scala b/finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Parameter.scala index 79889c6578..73d1906432 100644 --- a/finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Parameter.scala +++ b/finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Parameter.scala @@ -179,6 +179,7 @@ object Parameter { type A = Null def value: Null = null def evidence: CanBeParameter[Null] = CanBeParameter.nullCanBeParameter + override def toString: String = "Parameter(null)" } }