Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
finagle-core: Remove SslClientEngineFactory.getHostname
Problem The use of `SslClientEngineFactory.getHostname` is highly discouraged because it uses the `getHostName` method of the passed in `InetSocketAddress` if the hostname within the `SslClientConfiguration` is None. The `getHostName` method of `InetSocketAddress` performs a reverse DNS lookup when provided with an IP address, which is undesriable. Solution Remove `SslClientEngineFactory.getHostname` and encourage folks to use `SslClientEngineFactory.getHostString` instead. JIRA Issues: CSL-8416 Differential Revision: https://phabricator.twitter.biz/D334087
- Loading branch information
1 parent
54d4acf
commit 6e44cc3
Showing
3 changed files
with
8 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters