diff --git a/CHANGELOG.rst b/CHANGELOG.rst index acb3a6f9fb..8234dff850 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -15,6 +15,9 @@ Breaking API Changes of `GenSerialClientDispatcher` and `SerialClientDispatcher` have been removed. ``PHAB_ID=D342883`` +* finagle-thrift: The deprecated `ReqRepThriftServiceBuilder` object has been + removed. Users should migrate to `ReqRepMethodPerEndpointBuilder`. ``PHAB_ID=D345740`` + Runtime Behavior Changes ~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ReqRepThriftServiceBuilder.scala b/finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ReqRepThriftServiceBuilder.scala deleted file mode 100644 index d848099193..0000000000 --- a/finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ReqRepThriftServiceBuilder.scala +++ /dev/null @@ -1,13 +0,0 @@ -package com.twitter.finagle.thrift.service - -/** - * A typeclass to construct a ThriftService by wrapping a ReqRepServicePerEndpoint. - * - * This is a compatibility constructor to replace an existing Future interface with one built from - * a ReqRepServicePerEndpoint. - * - * Scrooge generates implementations of this builder. - */ -@deprecated("Use MethodPerEndpointBuilder", "2018-01-12") -trait ReqRepThriftServiceBuilder[ReqRepServicePerEndpoint, ThriftService] - extends ThriftServiceBuilder[ReqRepServicePerEndpoint, ThriftService]