Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

stream.HttpDechunker conflates last chunk with socket death #176

Closed
jdanbrown opened this Issue · 5 comments

3 participants

@stevegury

We can introduced a new object representing the "end of connection".
Unfortunately this change would require a version bump (at least minor) because it would make the code not backward compatible.
Would you like to submit a pull request?

@jdanbrown

How about reuse java.nio.channels.ClosedChannelException? I'll submit a pull request with that and we can change it if you think it'd be better to introduce a new exception object.

@jdanbrown

Rather, I'll use com.twitter.finagle.ChannelClosedException instead of java.nio.channels.ClosedChannelException.

@jdanbrown jdanbrown referenced this issue from a commit in jdanbrown/finagle
@jdanbrown jdanbrown Fix #176: stream.HttpDechunker shouldn't conflate last chunk with soc…
…ket death
df3e079
@jdanbrown

Submitted PR #179.

@mosesn
Owner

HttpDechunker is kaput! Thanks for the bug report.

@mosesn mosesn closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.