stream.HttpDechunker conflates last chunk with socket death #176

Closed
jdanbrown opened this Issue Jun 18, 2013 · 5 comments

Comments

3 participants
Contributor

stevegury commented Jun 18, 2013

We can introduced a new object representing the "end of connection".
Unfortunately this change would require a version bump (at least minor) because it would make the code not backward compatible.
Would you like to submit a pull request?

Contributor

jdanbrown commented Jun 18, 2013

How about reuse java.nio.channels.ClosedChannelException? I'll submit a pull request with that and we can change it if you think it'd be better to introduce a new exception object.

Contributor

jdanbrown commented Jun 18, 2013

Rather, I'll use com.twitter.finagle.ChannelClosedException instead of java.nio.channels.ClosedChannelException.

@jdanbrown jdanbrown added a commit to jdanbrown/finagle that referenced this issue Jun 18, 2013

@jdanbrown jdanbrown Fix #176: stream.HttpDechunker shouldn't conflate last chunk with soc…
…ket death
df3e079
Contributor

jdanbrown commented Jun 18, 2013

Submitted PR #179.

Contributor

mosesn commented Apr 21, 2014

HttpDechunker is kaput! Thanks for the bug report.

mosesn closed this Apr 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment