New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set finagle-redis tests integration tests up to run as integration tests in SBT and Travis CI #360

Open
travisbrown opened this Issue Apr 6, 2015 · 1 comment

Comments

2 participants
@travisbrown
Contributor

travisbrown commented Apr 6, 2015

We're currently excluding the finagle-redis integration tests in the SBT build. We should move them to the appropriate location, configure SBT to treat them as integration tests, and set up the Travis CI build to have a Redis server available to run them. (If this has a large impact on the Travis CI testing times we might need to turn them off there, but they currently run pretty quickly on my local machine.)

mkhq added a commit to mkhq/finagle that referenced this issue Jul 22, 2015

Enable running integration tests in the finagle-redis project.
Problem

Unit tests and integration tests are mixed in the finagle-redis project under the test path. In addition, the SBT configuration is only running unit tests. This partially solves issue #360.

Solution

Moved the integration test files to the  path from . Extracted traits used for integration tests and created a new file in the  path. Added configuration for IntegrationTest in the finagle-redis project.

Result

Running 'test' only executes unit tests. Running 'it:test' executes the integration tests.

mkhq added a commit to mkhq/finagle that referenced this issue Aug 16, 2016

finagle-redis: Enable running integration tests in finagle-redis.
Problem

Unit tests and integration tests are mixed in the finagle-redis project
under the test path. In addition, the SBT configuration is only running
unit tests. This partially solves issue #360.

Solution

Moved the integration test files to the  path from . Extracted traits
used for integration tests and created a new file in the  path. Added
configuration for IntegrationTest in the finagle-redis project.

Result

Running 'test' only executes unit tests. Running 'it:test' executes the
integration tests.

mkhq added a commit to mkhq/finagle that referenced this issue Aug 11, 2017

finagle-redis: Enable running integration tests in finagle-redis.
Problem

Unit tests and integration tests are mixed in the finagle-redis project
under the test path. In addition, the SBT configuration is only running
unit tests. This solves issue #360.

Solution

Added configuration for IntegrationTest in the finagle-redis project
and moved integration tests to the correct path. Redis process shutdown
always includes all processes.

Result

Running 'test' only executes unit tests. Running 'it:test' executes the
integration tests.

mkhq added a commit to mkhq/finagle that referenced this issue Aug 11, 2017

finagle-redis: Enable running integration tests in finagle-redis.
Problem

Unit tests and integration tests are mixed in the finagle-redis project
under the test path. In addition, the SBT configuration is only running
unit tests. This solves issue #360.

Solution

Added configuration for IntegrationTest in the finagle-redis project
and moved integration tests to the correct path. Redis process shutdown
always includes all processes.

Result

Running 'test' only executes unit tests. Running 'it:test' executes the
integration tests.

finaglehelper pushed a commit that referenced this issue Sep 13, 2017

finagle-redis: Enable running integration tests in finagle-redis.
Summary: Problem

Unit tests and integration tests are mixed in the finagle-redis project
under the test path. In addition, the SBT configuration is only running
unit tests. This solves issue #360.

Solution

Added configuration for IntegrationTest in the finagle-redis project
and moved integration tests to the correct path. Redis process shutdown
always includes all processes.

Result

Running 'test' only executes unit tests. Running 'it:test' executes the
integration tests.

Signed-off-by: Bryce Anderson <banderson@twitter.com>

Differential Revision: https://phabricator.twitter.biz/D90176

@smlance smlance self-assigned this Aug 24, 2018

@smlance

This comment has been minimized.

Show comment
Hide comment
@smlance

smlance Aug 24, 2018

Member

The integration tests have a Pants target as of 0f96f6c but they don't yet run in Travis.

Member

smlance commented Aug 24, 2018

The integration tests have a Pants target as of 0f96f6c but they don't yet run in Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment