added new commands #106

Closed
wants to merge 12 commits into
from

Conversation

4 participants
Contributor

mosesn commented Sep 5, 2012

list commands:
LLEN
LINDEX
LINSERT
LPOP
LPUSH
LREM
LSET
LRANGE
RPOP
RPUSH
LTRIM

Misc:
TTL
EXPIRE

Set commands:
SADD
SREM
SMEMBERS
SCARD
SISMEMBER
SPOP

Sorted Set Commands:
ZINCRBY
ZRANGE
ZRANK
ZREMRANGEBYSCORE
ZREMRANGEBYRANK
ZREVRANK

mosesn and others added some commits Aug 1, 2012

mostly just formatting changes, added naggati spec tests
also moved around some code which semantically made more
sense elsewhere.
Merge pull request #1 from tumblr/more_redis_client
added new list commands, ttl commands, and tests for them.
Merge branch 'master' of github.com:twitter/finagle
Conflicts:
	finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/Command.scala
	finagle-redis/src/test/scala/com/twitter/finagle/redis/integration/ClientSpec.scala
Merge remote-tracking branch 'upstream/master'
Conflicts:
	finagle-redis/src/main/scala/com/twitter/finagle/redis/Client.scala
	finagle-redis/src/main/scala/com/twitter/finagle/redis/util/Conversions.scala
	finagle-redis/src/test/scala/com/twitter/finagle/redis/integration/ClientServerIntegrationSpec.scala
	finagle-redis/src/test/scala/com/twitter/finagle/redis/integration/ClientSpec.scala
Contributor

zhanggl commented Sep 26, 2012

I am wondering when will these commits be merged to finagle-redis, because I really need these missing redis commands.

Contributor

mosesn commented Sep 26, 2012

Hopefully in a few days. A big change was just made to finagle-redis, and I need to update these commands to make it work with the new scheme. However, finagle currently doesn't build, so I can't work on it. In the mean time, feel free to clone the tumblr repository, which already has these commands. You can publish-local, and then build using that.

Contributor

mosesn commented Sep 27, 2012

@zhanggl this pull request is now up to date with the rest of finagle, tested, and should work properly. I hope it's useful to you!

Contributor

mosesn commented Sep 27, 2012

@anirudh This PR is ready to rock! Please give it a lookover, I think it's pretty good right now.

Contributor

zhanggl commented Sep 29, 2012

Thanks @mosesn , Good Job!

Hey @mosesn, this has been pulled internally. Thanks!

@asrinivas asrinivas closed this Oct 1, 2012

Contributor

mosesn commented Oct 1, 2012

sweet, when should I expect to see this in master?

kil9 pushed a commit to kil9/finagle that referenced this pull request Feb 26, 2014

[split] added new commands list commands: LLEN LINDEX LINSERT LPOP LP…
…USH LREM LSET LRANGE RPOP RPUSH LTRIM

Misc:
TTL
EXPIRE

Set commands:
SADD
SREM
SMEMBERS
SCARD
SISMEMBER
SPOP

Sorted Set Commands:
ZINCRBY
ZRANGE
ZRANK
ZREMRANGEBYSCORE
ZREMRANGEBYRANK
ZREVRANK
Github-pull-request: twitter#106

Signed-off-by: Anirudh Srinivas <anirudhs@twitter.com>

RB_ID=88832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment