Fix arg type in RetryingFilter.apply #108

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@jdanbrown
Contributor

RetryingFilter.apply should let its shouldRetry argument take a Try[Nothing] instead of a Try[Rep], since it's immediately turned into a RetryPolicy[Try[Nothing]].

@jdanbrown jdanbrown Fix arg type in RetryingFilter.apply
`RetryingFilter.apply` should let its `shouldRetry` argument take a `Try[Nothing]` instead of a `Try[Rep]`, since it's immediately turned into a `RetryPolicy[Try[Nothing]]`.
3bfb16e
@stevegury
Contributor

Thanks!
I pulled this internally.

@stevegury stevegury closed this Sep 15, 2012
@kil9 kil9 pushed a commit to kil9/finagle that referenced this pull request Feb 26, 2014
@jdanbrown @stevegury jdanbrown + stevegury [split] Fix arg type in RetryingFilter.apply
`RetryingFilter.apply` should let its `shouldRetry` argument take a
`Try[Nothing]` instead of a `Try[Rep]`, since it's immediately turned
into a `RetryPolicy[Try[Nothing]]`.

Github-pull-request: twitter#108
Signed-off-by: Steve Gury <stevegury@twitter.com>

RB_ID=86676
b29ed9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment