Fixed the empty string issue when decoding MBULK_REPLY #251

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@zhanggl
Contributor
zhanggl commented Mar 8, 2014

Motivations:

A $0\r\n\r\n being one element of a MBULK_REPLY from a Redis server should be decoded to a BulkReply of "", not a EmptyBulkReply.

Modifications:

  1. Fixed the if statement to catch $0\r\n\r\n
  2. And the tests in both NaggatiSpec.scala and ClientSpec.scala

Results:

Now we can have $0\r\n\r\n being properly decoded.

Contributor
zhanggl commented Mar 8, 2014

@mosesn
Sorry for the delay, please check it out.

lgtm!

Contributor

It looks good to me too.
I'm merging it internally in our repo, it should be available here in a few days.

Thank you @zhanggl for your contributions!

Contributor
zhanggl commented Mar 12, 2014

Great. Thanks.
I'll check other redis commands for the same issue when my time is available.

Contributor
mosesn commented Apr 10, 2014

This was merged a while ago, thanks! Closing the issue.

@mosesn mosesn closed this Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment