Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
GSoC: finagle-smtp - initial #287
This is initial version of SMTP client for Finagle, which I am working on during GSoC'14.
I see that this build failure is not a result of these proposed code changes
error sbt.ResolveException: unresolved dependency: com.twitter#util-core_2.9.2;6.18.0: not found
and http://mvnrepository.com/artifact/com.twitter/util-core_2.9.2 does not have 6.18.0
Any ideas on how to proceed?
This looks generally good, but there are a few pieces that seem like they might fit better in the dispatcher than where they are right now. I'd be interested in seeing some more end to end tests. The testing could definitely be a little more thorough.
However, most of my suggestions are nitpicks. In general, this looks quite good! Great job.