New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatjar includes unexpected assets in the public directory #147

Closed
eggsby opened this Issue May 30, 2014 · 1 comment

Comments

2 participants
@eggsby

eggsby commented May 30, 2014

When using the provided pom from 'finatra new ____' the package step results in unexpected files being included.

Things like the default app index.html, favicon.ico and others will be overlaid on top of the project resources, making it impossible to use these files in your one jar.

Steps to reproduce:

  • Make a finatra app
  • change the contents of the index.html
  • run the uberjar
    • the index.html changes are not reflected, the transitive sample index.html shows

Version info:

java: oracle 1.7.0_55
os: ubuntu 14.04
mvn: 3.2.1
finatra: 1.5.2

@scosenza

This comment has been minimized.

Contributor

scosenza commented Aug 15, 2015

Finatra v2 supports both sbt and Maven for producing deployable services. When using the Maven support, we no longer create an uber-jar which should avoid this issue.

@scosenza scosenza closed this Aug 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment