New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorHandler used by ControllerCollection depends on order Controllers are added #182

Closed
marcthehappy opened this Issue Nov 27, 2014 · 1 comment

Comments

2 participants
@marcthehappy

marcthehappy commented Nov 27, 2014

Adding a new Controller using ControllerCollection's add method sets the ErrorHandler and notFoundHandler to those of the new Controller. This is unexpected, as I would expect the errorHandler and notFoundHandler of the Controller in a ControllerCollection handling a request to be used.

plaflamme added a commit to plaflamme/finatra that referenced this issue Jan 7, 2015

FIX: issue twitter#182, let controller's error handler handle its own…
… errors.

This is a partial fix for issue twitter#182. It allows a controller's error handler to handle its own errors. It still uses the "last" registered handler as the global error handler. Fixing that would require API changes.

capotej added a commit that referenced this issue Jan 7, 2015

Merge pull request #188 from plaflamme/fix-error-handlers
FIX: issue #182, let controller's error handler handle its own errors.

cacoco pushed a commit that referenced this issue May 13, 2015

FIX: issue #182, let controller's error handler handle its own errors.
This is a partial fix for issue #182. It allows a controller's error handler to handle its own errors. It still uses the "last" registered handler as the global error handler. Fixing that would require API changes.

cacoco pushed a commit that referenced this issue May 13, 2015

Merge pull request #188 from plaflamme/fix-error-handlers
FIX: issue #182, let controller's error handler handle its own errors.

cacoco pushed a commit that referenced this issue May 14, 2015

FIX: issue #182, let controller's error handler handle its own errors.
This is a partial fix for issue #182. It allows a controller's error handler to handle its own errors. It still uses the "last" registered handler as the global error handler. Fixing that would require API changes.

cacoco pushed a commit that referenced this issue May 14, 2015

Merge pull request #188 from plaflamme/fix-error-handlers
FIX: issue #182, let controller's error handler handle its own errors.
@cacoco

This comment has been minimized.

Member

cacoco commented Jun 3, 2015

No longer pertinent in Finatra v2.x.

@cacoco cacoco closed this Jun 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment