New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatSpecHelper dependency missing in finagle 1.6.0 #189

Closed
edwelker opened this Issue Jan 16, 2015 · 3 comments

Comments

3 participants
@edwelker
Contributor

edwelker commented Jan 16, 2015

Found in commit 5d1d1cb.

Clone the repo, ./finatra new com.domain.whatever, and then sbt test fails. It seems that

com/twitter/finatra/test/FlatSpecHelper.scala

isn't included in finagle 1.6.0 as it is in previous versions. Manually adding that file back to your project corrects the issue.

@gonfva

This comment has been minimized.

gonfva commented Jan 30, 2015

Same here. The problem seems to be this commit 5c2395f

Apparently that commit wanted to remove Scalatest as a the dependency for the apps using the framework (and keep it as a dependency of building the framework).

Unfortunately that means that the the project generated by default does not compile(since it includes the file AppSpec that depends on FlatSpecHelper).

Probably, the easiest solution is to include FlatSpecHelper to the project generated by default (maybe here https://github.com/twitter/finatra/blob/master/script/finatra/libexec/finatra-new )

@edwelker

This comment has been minimized.

Contributor

edwelker commented Jan 30, 2015

Yep, issue #179.

@caniszczyk

This comment has been minimized.

Contributor

caniszczyk commented May 1, 2015

Finagle 2.0M1 is out now for comment so closing out this old issue

https://github.com/twitter/finatra#features

@caniszczyk caniszczyk closed this May 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment