New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-type custom settings do not work when render json #191

Closed
itang opened this Issue Jan 29, 2015 · 2 comments

Comments

3 participants
@itang

itang commented Jan 29, 2015

Finatra version: 1.6.0

The sample code as below:

render.status(status).json(v).contentType("application/json; charset=utf-8").toFuture

But the Content-Type of response was 'application/json’

Note ResponseBuilder#setContent method:

private def setContent(resp: HttpResponse): HttpResponse = {
    json match {
      case Some(j) =>
        resp.headers.set("Content-Type", "application/json")  // !! Swept away?
        ...

@cacoco cacoco closed this Jun 3, 2015

@timoreimann

This comment has been minimized.

timoreimann commented Jun 22, 2015

Was this issue closed without a comment because development on Finatra version 1 stopped in favor of version 2?

If so, it'd still be great to receive bug fixes for version 1.

@cacoco

This comment has been minimized.

Member

cacoco commented Jun 24, 2015

@timoreimann yes. As of now there is no plan to continue support for version 1, sorry.

However, we are more than happy to help migrate your services to version 2.x. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment