New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multipart PUT requests #194

Closed
bpfoster opened this Issue Mar 4, 2015 · 1 comment

Comments

2 participants
@bpfoster
Contributor

bpfoster commented Mar 4, 2015

It would appear there's nothing in the specs that restricts multipart requests to only POST.

In fact the documentation for the Netty HttpPostRequestDecoder (used by finatra for multipart parsing) states it "will decode Body and can handle POST BODY (or for PUT, PATCH or OPTIONS)." [1]

Given that, should finatra check for multipart bodies in all those methods?

[1] http://netty.io/4.0/api/io/netty/handler/codec/http/multipart/package-summary.html

bpfoster added a commit to bpfoster/finatra that referenced this issue Mar 4, 2015

@cacoco

This comment has been minimized.

Member

cacoco commented May 26, 2015

This was added in ec94853. Let me know if that does not solve your use case.

@cacoco cacoco closed this May 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment