Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable admin #208
Hi, I would like to disable the admin, too in some situations. However I don't have any problems with it yet, it's just dump when you need to configure multiple instances of finatra on a single server, ports clashing everywhere, so the less ports you need to configure, the better.
However I think it would still be great to have an admin module as a Guice Module, so we could just plug it in or plug it off easily.
Also it seems that
I mean i could just overwrite defaultHttpPort, but still awefull. Looks like the whole trait has no effect..
Really strange code. the port comes from the httpPortFlag, which has a default of :8888 and then there is httpExternalPort inside the Ports trait which also defaults to :8888, but is only used for the info?!
wouldn't it be better to have something like if flag is not empty override httpExternalPort, so we could either overwrite httpExternalPort OR use the httpPortFlag?
The Ports trait is not meant for configuration. Its purpose is to expose the ports during integration tests so that HTTP clients can point at the correct destination.
Okay, I will try.
On Thu, May 28, 2015, 14:15 Christopher Coco firstname.lastname@example.org
It's hacky but this works on Heroku.