Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Startup Test on doc #261

Closed
Raymond26 opened this issue Oct 6, 2015 · 1 comment
Closed

Update Startup Test on doc #261

Raymond26 opened this issue Oct 6, 2015 · 1 comment

Comments

@Raymond26
Copy link

@Raymond26 Raymond26 commented Oct 6, 2015

For Finatra 2.1.0, I copied the code for Startup Test and it didn't compile until I used new EmbeddedHttpServer(...) versus just EmbeddedHttpServer(....).

Also the flags required to prevent Finagle clients from making outbound connections didn't work for me. Were the flags removed/renamed?

[info] Exception encountered when attempting to run a suite with class name: com.cutesy.controllers.PetControllerTest *** ABORTED ***
[info]   com.twitter.app.FlagParseException: Error parsing flag "dtab.add": flag undefined
@cacoco
Copy link
Member

@cacoco cacoco commented Oct 6, 2015

Hi @Raymond26 that line is incorrect. We've updated the document accordingly. Thanks.

The proper way to do this is to set your com.twitter.server.resolverMap entries to nil!. You can always take a look at the working examples in the codebase underneath /examples.

For example, see the TwitterCloneStartupTest.

Thanks!

@cacoco cacoco closed this as completed Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants