Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of the http service name #270

Closed
adriancole opened this issue Oct 23, 2015 · 3 comments

Comments

@adriancole
Copy link

commented Oct 23, 2015

There's a significant population that label their services based on purpose, rather than transport. Right now, I can't see any clean way to override the service name of the http server as something besides "http".

https://github.com/twitter/finatra/blob/master/http/src/main/scala/com/twitter/finatra/http/internal/server/BaseHttpServer.scala#L128

I've tried overriding configureHttpServer and setting the name again there, but the original name of "http" sticks. The only option I've been able to get working is to override the entire tree of code around instantiating the http service.

Feels like this could be a flag.. Is there some way to make this easier?

@schrepfler

This comment has been minimized.

Copy link

commented Oct 23, 2015

Agreed, flag looks pretty straight forward especially since the class uses other flags as well.

@cacoco

This comment has been minimized.

Copy link
Member

commented Nov 5, 2015

This has been implemented in this commit: 7c9c983

@cacoco cacoco closed this Nov 5, 2015

@adriancole

This comment has been minimized.

Copy link
Author

commented Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.